Review main Merged

96307[BUGFIX] Skip move pointers without live record in versionOL

Georg Tiefenbrunn CR +2 V +2 Normal +57 −0 updated 10/09/26, 18:39

Commit message

PageRepository::versionOL() re-reads the live record of a move pointer.
If that record has been deleted, the query returns false,
which is passed on to getWorkspaceVersionOfRecord() and fails
with a TypeError, since its $liveRecord argument is typed as array.

Such move pointers are left over in installations upgraded
from older TYPO3 versions.
The row now stays false, which tells the caller to treat the record
as not accessible, as documented for $row.
A warning names the move pointer, the missing live record
and the workspace, so the orphaned row can be found and removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 911

  1. Georg Tiefenbrunn uploaded patch set 1 10/02/26, 11:37

  2. core-ci voted on patch set 1 V +1 10/02/26, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109923

  3. Benni Mack commented on patch set 1 10/02/26, 12:25

    could we add some logging so we know which live version was deleted?
  4. Georg Tiefenbrunn uploaded patch set 2 V +1 10/02/26, 12:44

  5. core-ci voted on patch set 2 V +1 10/02/26, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109936

  6. Benni Mack commented on patch set 2 CR +1 V +1 10/02/26, 12:58

    Reply

    Done
  7. Georg Tiefenbrunn commented on patch set 2 10/05/26, 11:00

    Reply

    Good point. A waring is logged with the table, uid of the move pointer, uid of the missing live record and the workspace, so the orphaned row can be found and removed. Warning rather than notice, so the default file writer picks it up.
  8. Josua Vogel voted on patch set 2 CR +1 10/08/26, 08:32

  9. Jochen Roth voted on patch set 2 CR +1 V +1 10/08/26, 10:57

  10. Benni Mack voted on patch set 2 CR +2 V +2 10/09/26, 18:39

  11. Benni Mack merged patch set 3 10/09/26, 18:39