96308[BUGFIX] Treat missing pages like deleted in modules
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 1
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/08/96308/1 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/08/96308/1 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -1 Needs a vote
- Benni Mack -1
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 4
Issues 1
Files 2
Review log 34
-
Georg Tiefenbrunn uploaded patch set 1 10/02/26, 11:37
-
core-ci voted on patch set 1 V +1 10/02/26, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109924
-
Benni Mack commented on patch set 1 CR -1 10/07/26, 16:31
-
Georg Tiefenbrunn commented on patch set 1 10/07/26, 19:14
BackendModuleValidator.php:255Reply UnresolveddoesUserHaveAccess() on the fetched row is not equivalent: calcPerms() additionally requires a web mount (fails for deleted pages) and grants nothing without user groups, so deleted pages with show permission get rejected. A single query works if the perms clause is evaluated in SQL: one unrestricted lookup selecting the delete field and CASE WHEN <perms clause> THEN 1 ELSE 0 END. It passes on SQLite, MariaDB, PostgreSQL and MySQL, but adds a literal SQL fragment, a ConnectionPool dependency and more code. This path only runs after readPageAccess() failed, so the second lookup is cheap. Keep the two getRecord() calls (optionally reordered, existence check only when the perms lookup finds nothing), or move the check into SQL? Either way I'd add tests for deleted pages with and without show permission, which are missing so far.
BackendModuleValidator.php:255