Review main Merged

96310[BUGFIX] Allow to delete record from single view

Markus Klein CR +2 V +2 Normal +74 −1 updated 10/05/26, 07:30

Commit message

If a non-admin user is editing a record, the delete-button was missing.
The check for the necessary permission was wrong.

PAGE_DELETE must only be used for 'pages'.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Anton Danilov +1
    • Josef Glatz +1
    • Georg Ringer +1
    • Oliver Klee +1
    • Johannes Kasberger +1
    • Sebastian Iffland +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Anton Danilov +1
    • Josef Glatz +1
    • Georg Ringer +1
    • Oliver Klee +1
    • Johannes Kasberger +1
    • Sebastian Iffland +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1518

  1. Markus Klein uploaded patch set 1 10/02/26, 11:48

  2. Markus Klein updated the commit message in patch set 2 10/02/26, 11:48

  3. Johannes Kasberger voted on patch set 2 CR +1 V +1 10/02/26, 11:49

  4. Sebastian Iffland voted on patch set 2 CR +1 10/02/26, 11:52

  5. core-ci voted on patch set 1 V +1 10/02/26, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109926

  6. core-ci voted on patch set 2 V +1 10/02/26, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109927

  7. Anton Danilov commented on patch set 2 V +1 10/02/26, 12:44

    Thanks, the fix is working for me. Since this is a bugfix, could you please add a test that reproduces the original problem and verifies the fix?
  8. Markus Klein uploaded patch set 3 CR +1 V +1 10/02/26, 21:43

  9. core-ci voted on patch set 3 V +1 10/02/26, 21:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110003

  10. Simon Schaufelberger commented on patch set 3 CR +1 V +1 10/02/26, 22:00

    Reply

    Done
  11. Anton Danilov voted on patch set 3 CR +1 V +1 10/03/26, 09:02

  12. Georg Ringer voted on patch set 3 CR +1 V +1 10/03/26, 17:47

  13. Josef Glatz voted on patch set 3 CR +1 V +1 10/04/26, 01:52

  14. Oliver Klee voted on patch set 3 CR +1 V +1 10/04/26, 13:22

  15. Johannes Kasberger voted on patch set 3 CR +1 V +1 10/05/26, 06:52

  16. Sebastian Iffland voted on patch set 3 CR +1 V +1 10/05/26, 06:54

  17. Oli Bartsch voted on patch set 3 CR +2 V +2 10/05/26, 07:30

  18. Oli Bartsch merged patch set 4 10/05/26, 07:30