96313[BUGFIX] Persist task parameters in SchedulerTaskRepository
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1014
-
Simon Schaufelberger uploaded patch set 1 10/02/26, 12:25
-
core-ci voted on patch set 1 V -1 10/02/26, 12:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109933
-
Simon Schaufelberger uploaded patch set 2
V -110/02/26, 12:58 -
core-ci voted on patch set 2 V +1 10/02/26, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109939
-
Simon Schaufelberger uploaded patch set 3
V +110/02/26, 15:02 -
core-ci voted on patch set 3 V +1 10/02/26, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109954
-
Oli Bartsch commented on patch set 3 V -1 10/05/26, 15:56
The add() only covers native tasks whose parameters are all TCA columns. Two cases are still broken: - Console command tasks keep their arguments and options in parameters. add() merges them as top-level fields, DataHandler drops them, and the task comes back with [] options. - update($task) has the same problem for every native task. Both come from TaskService::getFieldsForRecord() ignoring parameters for native tasks. Fixing it there, the same way TaskSerializer reads them (columns from additionalFields, everything else into parameters), covers add() and update() and makes the special case in add() unnecessary. I'll push a patch set doing that. -
Oli Bartsch uploaded patch set 4
V +110/05/26, 15:57 -
Oli Bartsch commented on patch set 4 10/05/26, 15:58
Reply
Done, please check if the changes are fine for you. -
core-ci voted on patch set 4 V +1 10/05/26, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110128
-
Simon Schaufelberger commented on patch set 4 CR +1 V +1 10/05/26, 16:12
Reply
Acknowledged -
Benni Mack voted on patch set 4 CR +1 V +1 10/06/26, 11:14
-
Benni Mack voted on patch set 4 CR +2 V +2 10/07/26, 15:09
-
Benni Mack merged patch set 5 10/07/26, 15:09