Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
96319[FEATURE] Undo operations from their notification
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 8
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/19/96319/8 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/19/96319/8 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V +1 Needs a vote
- Garvin Hicking +1
- core-ci +1 CI
Issues 3
Files 50
- Build/Sources/TypeScript/backend/ajax-data-handler/response-interface.ts+2 −0
- Build/Sources/TypeScript/backend/tests/ajax-data-handler-test.tsnew+56 −0
- Build/Sources/TypeScript/backend/tests/operation-undo-test.tsnew+240 −0
- Build/Sources/TypeScript/backend/tree/page-tree-element.ts+4 −0
- Build/Sources/TypeScript/backend/wizard/move-content-element.ts+4 −2
- Build/Sources/TypeScript/backend/wizard/move-page.ts+4 −2
- Build/Sources/TypeScript/backend/ajax-data-handler.ts+13 −1
- Build/Sources/TypeScript/backend/operation-undo.tsnew+158 −0
- Build/Sources/TypeScript/backend/recordlist.ts+36 −0
- Build/tests/playwright/e2e/page-tree/page-tree-undo.spec.tsnew+38 −0
- Build/tests/playwright/e2e/records/undo-delete.spec.tsnew+79 −0
- Build/tests/playwright/e2e/records/undo-move-wizard.spec.tsnew+26 −0
- Build/tests/playwright/e2e/records/undo-row-actions.spec.tsnew+78 −0
- Build/types/TYPO3/index.d.ts+1 −0
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php+19 −6
- typo3/sysext/backend/Classes/Controller/BackendController.php+4 −0
- typo3/sysext/backend/Classes/Controller/OperationUndoController.phpnew+78 −0
- typo3/sysext/backend/Classes/Controller/RecordListController.php+11 −7
- typo3/sysext/backend/Classes/Controller/SimpleDataHandlerController.php+17 −1
- typo3/sysext/backend/Classes/History/OperationHistoryRepository.phpnew+149 −0
Show 30 more files
- typo3/sysext/backend/Classes/History/OperationUndo.phpnew+404 −0
- typo3/sysext/backend/Classes/History/OperationUndoException.phpnew+33 −0
- typo3/sysext/backend/Classes/History/OperationUndoNotification.phpnew+130 −0
- typo3/sysext/backend/Classes/History/OperationUndoState.phpnew+48 −0
- typo3/sysext/backend/Classes/History/RecordHistory.php+34 −16
- typo3/sysext/backend/Classes/History/RecordHistoryRollback.php+30 −2
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+41 −38
- typo3/sysext/backend/Configuration/Backend/AjaxRoutes.php+7 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_show_rechis.xlf+81 −0
- typo3/sysext/backend/Resources/Public/JavaScript/tree/page-tree-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/wizard/move-content-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/wizard/move-page.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ajax-data-handler.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/operation-undo.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/recordlist.js+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/OperationUndoControllerTest.phpnew+250 −0
- typo3/sysext/backend/Tests/Functional/History/Fixtures/OperationMovingARecordTwice.csvnew+4 −0
- typo3/sysext/backend/Tests/Functional/History/Fixtures/OperationStoredScope.csvnew+3 −0
- typo3/sysext/backend/Tests/Functional/History/Fixtures/OperationUndo.csvnew+16 −0
- typo3/sysext/backend/Tests/Functional/History/Fixtures/OperationUndoEditor.csvnew+6 −0
- typo3/sysext/backend/Tests/Functional/History/Fixtures/OperationUndoFileReferences.csvnew+4 −0
- typo3/sysext/backend/Tests/Functional/History/Fixtures/OperationUndoSecondSite.csvnew+4 −0
- typo3/sysext/backend/Tests/Functional/History/Fixtures/OperationUndoTranslation.csvnew+3 −0
- typo3/sysext/backend/Tests/Functional/History/OperationUndoTest.phpnew+532 −0
- typo3/sysext/backend/Tests/Functional/History/RecordHistoryRollbackTest.php+24 −0
- typo3/sysext/backend/Tests/Functional/History/RecordHistoryStoreTest.php+18 −0
- typo3/sysext/backend/Tests/Functional/History/RecordHistoryTest.php+27 −0
- typo3/sysext/core/Classes/DataHandling/History/RecordHistoryStore.php+21 −7
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-110825-UndoOperationsFromTheirNotification.rstnew+127 −0
- typo3/sysext/core/ext_tables.sql+3 −1
Review log 1220
-
Oli Bartsch uploaded patch set 1 10/02/26, 15:31
-
core-ci voted on patch set 1 V -1 10/02/26, 15:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109963
-
Oli Bartsch uploaded patch set 2
V -110/02/26, 19:42 -
core-ci voted on patch set 2 V +1 10/02/26, 19:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109991
-
Oli Bartsch rebased onto patch set 3
V +110/05/26, 15:02 -
core-ci voted on patch set 3 V +1 10/05/26, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110124
-
Oli Bartsch uploaded patch set 4
V +110/07/26, 20:25 -
core-ci voted on patch set 4 V +1 10/07/26, 20:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110407
-
Oli Bartsch rebased onto patch set 5
V +110/09/26, 17:55 -
core-ci voted on patch set 5 V +1 10/09/26, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110664
-
Oli Bartsch uploaded patch set 6
V +110/13/26, 07:34 -
core-ci voted on patch set 6 V +1 10/13/26, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110985
-
Oli Bartsch uploaded patch set 7
V +110/19/26, 09:36 -
core-ci voted on patch set 7 V +1 10/19/26, 09:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111615
-
Simon Schaufelberger commented on patch set 7 CR +1 V +1 10/19/26, 21:24
works great! -
Garvin Hicking commented on patch set 7 10/20/26, 07:51
Notifications only show up for the "Layout" module while with this commit message I would expect it in the "Records" module. We might want/need to use the notifications in the record module too for consistency, unless this is intentional? -
Oli Bartsch uploaded patch set 8
CR +1V +110/21/26, 07:15 -
core-ci voted on patch set 8 V +1 10/21/26, 07:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111973
-
Oli Bartsch commented on patch set 8 10/21/26, 07:37
Reply
Thanks, good catch. The Records module still ran its row actions through the tce_db redirect, which cannot carry the undo offer. With this patch set it processes deleting, moving up/down and between levels and pasting from the clipboard through record_process, so all of them offer the undo. -
Garvin Hicking commented on patch set 8 V +1 10/21/26, 10:39
This works nicely for me. I can't judge any of the TS though.