Review 14.3 Merged

96322[BUGFIX] Skip stdWrap cache write if caching is disabled

Benni Mack CR +2 V +2 Normal +114 −0 updated 10/05/26, 14:18

Commit message

The stdWrap function "cache" wrote its content to the "hash" cache
even when caching was disabled for the current request, for instance
during a backend user preview of hidden pages and records. Regular
visitors were served that poisoned cache entry afterwards.

Writing is now guarded by the same isCachingAllowed() check that
already protects reading and the "cache" property of content objects.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 46

  1. Benni Mack commented on patch set 1 10/02/26, 16:29

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 10/02/26, 16:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109973

  3. Benni Mack commented on patch set 2 V -1 10/05/26, 13:45

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 10/05/26, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110119

  5. Benni Mack voted on patch set 2 CR +2 V +2 10/05/26, 14:18

  6. Benni Mack merged patch set 3 10/05/26, 14:18