Review main Merged

96324[BUGFIX] Use page id to resolve live version of copied children

Benni Mack CR +2 V +2 Normal +125 −4 updated 10/03/26, 07:05

Commit message

When the pid of inline children is updated after a page was copied or
versioned, the live version of the page was looked up with the uid of
the child's parent record instead of the page id.

If a page with that uid has a workspace version, nested children were
moved to the live page of that version, an unrelated page. This
happens whenever uids of the parent table and pages overlap, also in
live as soon as the workspaces extension is installed.

The live version is now resolved with the page id. The lookup itself
is still needed: when a page is versioned in a workspace, the page id
is the workspace version and must be mapped to the live page.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 56

  1. Benni Mack uploaded patch set 1 10/02/26, 16:38

  2. core-ci voted on patch set 1 V +1 10/02/26, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109976

  3. Oli Bartsch voted on patch set 1 CR +1 V +1 10/02/26, 19:59

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 10/03/26, 07:04

  5. Benni Mack voted on patch set 1 CR +2 V +2 10/03/26, 07:05

  6. Benni Mack merged patch set 2 10/03/26, 07:05