96328[TASK] Enable tool credits in AGENTS.md
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 1
Review log 911
-
Benjamin Franzke uploaded patch set 1 10/02/26, 18:14
-
core-ci voted on patch set 1 V +1 10/02/26, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109983
-
Benjamin Franzke uploaded patch set 2
V +110/02/26, 18:30 -
core-ci voted on patch set 2 V +1 10/02/26, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109986
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/02/26, 19:45
-
Benni Mack commented on patch set 2 10/03/26, 12:36
I don't recall that we decided on this change in our last team meeting, whereas I had the task to evaluate this from our last team meeting. OTOH I am not aware that the Core Team communicated to the Docs Team any changes to our coding guidelines or commit message formats in the recent past, same as I am not aware that the Docs Team is responsible for defining the commit message format... can you point me to the communication that I missed? -
Simon Schaufelberger wrote 10/03/26, 13:41
Removed reviewer Simon Schaufelberger with the following votes: * Verified+1 by Simon Schaufelberger * Code-Review+1 by Simon Schaufelberger -
Stefan Bürk commented on patch set 2 10/04/26, 20:50
Reply
Same.That's commit messages for "documentation commits" - not core. Core Contribution Commit Messages -> https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/CommitMessage.html#commitmessage -
Garvin Hicking commented on patch set 2 10/05/26, 04:55
Reply
I also think we should discuss our stance on it, the assoc post is a recommendation that the docs team followed, but for us I think it can have different dimensions. I was also under the inpression that Benni actively worked on navigating this before we act. -
Benjamin Franzke abandoned the change 10/05/26, 05:32
-
Benjamin Franzke commented on patch set 2 10/05/26, 06:51
Reply
Sorry, I should have pushed this as WIP. I was playing with AI and wanted a working environment where signoffs aren't added automatically and tool credits are enabled: > 96354: [TASK] Speedup e2e install by respecting initCommands in setup command | https://review.typo3.org/c/Packages/TYPO3.CMS/+/96354 > 96353: [TASK] Speed up styleguide demo data generation | https://review.typo3.org/c/Packages/TYPO3.CMS/+/96353 I didn't mean to offend anyone with pushing this patch. Sorry. Abandoning here, since this was perceived differently. Hope we can clarify that.Reply Unresolved
thanks, i mixed those up, sorry.