Review main Abandoned

96328[TASK] Enable tool credits in AGENTS.md

Benjamin Franzke CR 0 V 0 Easy +3 −1 updated 10/05/26, 06:51

Commit message

Include AI assistance git trailers as documented
as a requirement for commit messages on:
https://docs.typo3.org/permalink/h2document:commit-messages-format

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Benjamin Franzke uploaded patch set 1 10/02/26, 18:14

  2. core-ci voted on patch set 1 V +1 10/02/26, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109983

  3. Benjamin Franzke uploaded patch set 2 V +1 10/02/26, 18:30

  4. core-ci voted on patch set 2 V +1 10/02/26, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109986

  5. Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/02/26, 19:45

  6. Benni Mack commented on patch set 2 10/03/26, 12:36

    I don't recall that we decided on this change in our last team meeting, whereas I had the task to evaluate this from our last team meeting. OTOH I am not aware that the Core Team communicated to the Docs Team any changes to our coding guidelines or commit message formats in the recent past, same as I am not aware that the Docs Team is responsible for defining the commit message format... can you point me to the communication that I missed?
  7. Simon Schaufelberger wrote 10/03/26, 13:41

    Removed reviewer Simon Schaufelberger with the following votes: * Verified+1 by Simon Schaufelberger * Code-Review+1 by Simon Schaufelberger
  8. Stefan Bürk commented on patch set 2 10/04/26, 20:50

    Reply

    Same.
    That's commit messages for "documentation commits" - not core. Core Contribution Commit Messages -> https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/CommitMessage.html#commitmessage
  9. Garvin Hicking commented on patch set 2 10/05/26, 04:55

    Reply

    I also think we should discuss our stance on it, the assoc post is a recommendation that the docs team followed, but for us I think it can have different dimensions. I was also under the inpression that Benni actively worked on navigating this before we act.
  10. Benjamin Franzke abandoned the change 10/05/26, 05:32

  11. Benjamin Franzke commented on patch set 2 10/05/26, 06:51

    Reply

    Sorry, I should have pushed this as WIP. I was playing with AI and wanted a working environment where signoffs aren't added automatically and tool credits are enabled: > 96354: [TASK] Speedup e2e install by respecting initCommands in setup command | https://review.typo3.org/c/Packages/TYPO3.CMS/+/96354 > 96353: [TASK] Speed up styleguide demo data generation | https://review.typo3.org/c/Packages/TYPO3.CMS/+/96353 I didn't mean to offend anyone with pushing this patch. Sorry. Abandoning here, since this was perceived differently. Hope we can clarify that.

    Reply Unresolved

    thanks, i mixed those up, sorry.