96333[TASK] Avoid duplicate file-cache size reads
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oliver Klee +1
- Alexander Schnitzler +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oliver Klee +1
- Alexander Schnitzler +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1516
-
Wouter Wolters uploaded patch set 1 10/02/26, 19:50
-
Wouter Wolters updated the commit message in patch set 2 10/02/26, 20:06
-
Wouter Wolters updated the commit message in patch set 3 10/02/26, 20:09
-
Wouter Wolters updated the commit message in patch set 4 10/09/26, 18:32
-
Wouter Wolters rebased onto patch set 5 10/09/26, 18:32
-
Wouter Wolters wrote 10/09/26, 18:33
Unset private -
Wouter Wolters marked it ready for review 10/09/26, 18:33
-
core-ci voted on patch set 5 V +1 10/09/26, 18:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110683
-
Simon Schaufelberger commented on patch set 5 10/17/26, 17:36
FileBackend.php:34I'm not sure if a RuntimeCache would be better here because I think the core team doen't like local cache variables so much -
Alexander Schnitzler commented on patch set 5 10/18/26, 06:53
FileBackend.php:34ReplyWhat do you mean with a RuntimeCache here? A static variable is a first level runtime cache. We have those in various places. Extbase uses those in the Reflection area quite a lot. Not sure who doesn’t like this pattern but I would build this like Wouter does here. -
Oliver Klee voted on patch set 5 CR +1 V +1 10/18/26, 09:23
-
Simon Schaufelberger commented on patch set 5 10/18/26, 12:21
FileBackend.php:34ReplyI mean the runtime cache from the caching framework. Just wanted to mention this, I'm not asking to change it. -
Alexander Schnitzler voted on patch set 5 CR +1 V +1 10/18/26, 13:34
-
Georg Ringer voted on patch set 5 CR +1 V +1 11/01/26, 16:04
-
Benni Mack commented on patch set 5 CR +2 V +2 11/09/26, 13:48
FileBackend.php:34ReplyDone -
Benni Mack merged patch set 6 11/09/26, 13:48