Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
96335[BUGFIX] Skip validating collections without element validators
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 1
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/35/96335/1 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/35/96335/1 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Simon Schaufelberger +1
-
Verified V +1 Needs a vote
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/core/Documentation/Changelog/14.3.x/Important-91678-ExtbaseSkipsCollectionsWithoutValidationRules.rstnew+40 −0
- typo3/sysext/extbase/Classes/Validation/Validator/CollectionValidator.php+15 −9
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php+82 −9
- typo3/sysext/extbase/Tests/Functional/Validation/Fixtures/BaseValidatorConjunctionTestImport.csvnew+6 −0
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/CollectionValidatorTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Validation/BaseValidatorConjunctionTest.phpnew+79 −0
Review log 34
-
Benni Mack uploaded patch set 1 10/02/26, 20:25
-
core-ci voted on patch set 1 V +1 10/02/26, 20:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109999
-
Benni Mack marked it ready for review 10/07/26, 15:16
-
Simon Schaufelberger commented on patch set 1 CR +1 V +1 10/08/26, 00:24
I guess this is a huge performance improvement when you have plenty of models that depend on each other