Review main Merged

96339[TASK] Avoid test method name clash with PHPUnit 13.4

Georg Ringer CR +2 V +2 Easy +2 −2 updated 10/03/26, 06:46

Commit message

PHPUnit 13.4 adds a private TestCase::verifyTest() method. As
test methods are invoked from within TestCase, the private parent
method is called instead of the test method, which fails with an
ArgumentCountError.

The affected test methods are renamed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Georg Ringer uploaded patch set 1 10/03/26, 04:32

  2. Georg Ringer commented on patch set 1 10/03/26, 04:32

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/03/26, 04:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110015

  4. Josua Vogel voted on patch set 1 CR +1 V +1 10/03/26, 05:48

  5. Benni Mack voted on patch set 1 CR +2 V +2 10/03/26, 06:04

  6. Georg Ringer merged patch set 2 10/03/26, 06:46