Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Quiet

96344[BUGFIX] Keep live and foreign MM rows when creating a version

Georg Ringer CR 0 V 0 Normal +106 −8 updated 10/03/26, 06:29

Commit message

When a record holding an MM relation is versioned in a workspace,
DataHandler::remapListedDBRecords_procDBRefs() rewrites the MM rows
of the live record: it purges all workspace records from the live
relations and writes the rest back.

This changes the sorting of live MM rows, leaves the reference index
of the live record dirty and deletes MM rows pointing to versions of
other workspaces, which then lose their relations.

Only the MM rows of the live record pointing to records of the current
workspace are taken over by the version, so only these rows are
removed now. All other MM rows of the live record are kept untouched.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/44/96344/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/44/96344/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 2

Files 2

Review log 24

  1. Georg Ringer uploaded patch set 1 10/03/26, 06:07

  2. Georg Ringer uploaded patch set 2 10/03/26, 06:20

  3. core-ci voted on patch set 1 V -1 10/03/26, 06:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110025

  4. core-ci voted on patch set 2 V +1 10/03/26, 06:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110027