Review main Merged

96352[BUGFIX] Fix order-dependent CreateRecordDryRunTest on MySQL

Oli Bartsch CR +2 V +2 Easy +4 −2 updated 10/04/26, 20:44

Commit message

The field map of a reaction is stored in a native JSON column
on MySQL, which normalizes object keys on storage: shorter keys
first, then binary order. The configured order is therefore not
preserved, while MariaDB, PostgreSQL and SQLite keep it.

The tests now assert the resolved fields and their labels
without relying on key order.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Oli Bartsch uploaded patch set 1 10/04/26, 19:46

  2. core-ci voted on patch set 1 V +1 10/04/26, 19:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110051

  3. Josua Vogel voted on patch set 1 CR +1 V +1 10/04/26, 20:38

  4. Stefan Bürk voted on patch set 1 CR +2 V +2 10/04/26, 20:44

  5. Stefan Bürk merged patch set 2 10/04/26, 20:44