Review main Merged

96353[TASK] Speed up styleguide demo data generation

Benjamin Franzke CR +2 V +2 Normal +176 −9 updated 10/06/26, 09:55

Commit message

Generating the TCA demo data hashed the same password once per
password field. Argon2 is slow by design, so hashing made up most of
the runtime. Hash each plain text password only once and reuse a
single hash for both demo backend users.

Additionally, all caches were flushed before every DataHandler run
on CLI, which the frontend generator executes five times. They are
now flushed once after all records have been written.

Measured runtime of the generator commands on a local SQLite instance:

* `styleguide:generate -c tca`: -9s
  (16 password hashes less, which require ~0.5s each)
* `styleguide:generate -c frontend`: -0.1s
  (4 cache flushes less)

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Wouter Wolters +1
    • Benjamin Kott +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Wouter Wolters +1
    • Benjamin Kott +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1012

  1. Benjamin Franzke uploaded patch set 1 10/05/26, 05:30

  2. core-ci voted on patch set 1 V +1 10/05/26, 05:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110065

  3. Benjamin Kott voted on patch set 1 CR +1 V +1 10/05/26, 09:38

  4. Benjamin Franzke rebased onto patch set 2 CR +1 V +1 10/05/26, 09:55

  5. Benjamin Franzke commented on patch set 1 10/05/26, 09:55

    I personally would have liked to mention this, but to follow AGENTS.md "Do not credit tooling or assistants in commit messages") I remove this line.
  6. Benjamin Franzke updated the commit message in patch set 3 10/05/26, 10:00

  7. Benjamin Kott voted on patch set 3 CR +1 V +1 10/05/26, 10:06

  8. core-ci voted on patch set 3 V +1 10/05/26, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110093

  9. Simon Schaufelberger voted on patch set 3 CR +1 V +1 10/05/26, 10:21

  10. Wouter Wolters voted on patch set 3 CR +1 V +1 10/05/26, 11:55

  11. Benjamin Franzke voted on patch set 3 CR +2 V +2 10/06/26, 06:33

  12. Benjamin Franzke merged patch set 4 10/06/26, 09:55