Review main Merged

96354[TASK] Speed up e2e setup by respecting initCommands in typo3 setup

Benjamin Franzke CR +2 V +2 Easy +15 −10 updated 10/06/26, 11:08

Commit message

`typo3 setup` replaced the default database connection configuration
with the values written to settings.php, which drops additions from
additional.php like initCommands. SetupDatabaseService now returns
the connection settings it wrote, and the setup command merges them
into the known connection configuration instead.

The e2e setup scripts only added their SQLite initCommands once a
driver was configured, which is not the case while `typo3 setup`
boots. They now also apply when TYPO3_DB_DRIVER requests SQLite.

Measured runtime of `typo3 setup` for the e2e instance:

* -15s, as creating the schema no longer syncs every single
  statement to disk (`PRAGMA synchronous = NORMAL`)

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Wouter Wolters +1
    • Benjamin Kott +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Wouter Wolters +1
    • Benjamin Kott +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 911

  1. Benjamin Franzke uploaded patch set 1 10/05/26, 05:30

  2. core-ci voted on patch set 1 V +1 10/05/26, 05:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110066

  3. Benjamin Franzke rebased onto patch set 2 V +1 10/05/26, 09:57

  4. Benjamin Franzke updated the commit message in patch set 3 10/05/26, 09:59

  5. Benjamin Franzke updated the commit message in patch set 4 10/05/26, 10:00

  6. Benjamin Kott voted on patch set 4 CR +1 V +1 10/05/26, 10:07

  7. core-ci voted on patch set 4 V +1 10/05/26, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110094

  8. Simon Schaufelberger voted on patch set 4 CR +1 V +1 10/05/26, 10:22

  9. Wouter Wolters voted on patch set 4 CR +1 V +1 10/05/26, 15:06

  10. Benjamin Franzke voted on patch set 4 CR +2 V +2 10/06/26, 09:59

  11. Benjamin Franzke merged patch set 5 10/06/26, 11:08