Review main Merged

96362[BUGFIX] Select type specific label fields for record titles

Oli Bartsch CR +2 V +2 Normal +76 −8 updated 10/08/26, 09:42

Commit message

With #108581, label fields can be defined per record type. Many
places however select the fields for the record title based on
the ctrl label configuration only. The type specific label
fields are therefore missing when BackendUtility::getRecordTitle()
resolves the title, which leads to "[No title]" or an incomplete
title, e.g. in the list module or for items of select fields.

LabelCapability::getLabelFieldNamesOfAllRecordTypes() now returns
the label fields of all record types of a schema, which is used
to select the necessary fields. The record type field is selected
as well, where it was missing.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 9

Review log 57

  1. Oli Bartsch uploaded patch set 1 10/05/26, 13:20

  2. core-ci voted on patch set 1 V +1 10/05/26, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110118

  3. Oli Bartsch rebased onto patch set 2 V +1 10/07/26, 20:17

  4. core-ci voted on patch set 2 V +1 10/07/26, 20:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110398

  5. Benni Mack voted on patch set 2 CR +1 V +1 10/07/26, 21:07

  6. Oli Bartsch voted on patch set 2 CR +2 V +2 10/08/26, 09:42

  7. Oli Bartsch merged patch set 3 10/08/26, 09:42