Review main Merged

96373[TASK] Reduce allocations in implodeAttributes

Wouter Wolters CR +2 V +2 Normal +58 −2 updated 11/09/26, 20:19

Commit message

Render XHTML attribute fragments during normalization instead of
collecting escaped values and rendering them in a second loop. Return
early for an empty attribute array and avoid escaping blank values that
will be omitted. Preserve escaping, attribute order and duplicate
handling.

Microbenchmarks on PHP 8.5 show 4-11% less time and 38-56% fewer
temporary allocations for six attributes. With 100 attributes,
temporary allocations drop by 34%, with a 2.5-3.4% time increase when
blank attributes are omitted.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1011

  1. Wouter Wolters uploaded patch set 1 10/05/26, 20:15

  2. Wouter Wolters updated the commit message in patch set 2 10/09/26, 18:16

  3. Wouter Wolters rebased onto patch set 3 10/09/26, 18:16

  4. Wouter Wolters wrote 10/09/26, 18:16

    Unset private
  5. Wouter Wolters marked it ready for review 10/09/26, 18:16

  6. core-ci voted on patch set 3 V +1 10/09/26, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110675

  7. Simon Schaufelberger voted on patch set 3 CR +1 V +1 10/17/26, 17:36

  8. Georg Ringer voted on patch set 3 CR +1 V +1 10/19/26, 17:57

  9. Oliver Klee voted on patch set 3 CR +1 V +1 10/19/26, 20:50

  10. Benni Mack voted on patch set 3 CR +2 V +2 11/09/26, 20:19

  11. Benni Mack merged patch set 4 11/09/26, 20:19