96376[BUGFIX] Detect capslock independent of shift key
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oli Bartsch +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 8
- Build/Sources/TypeScript/backend/login/capslock-warning.tsnew+84 −0
- Build/Sources/TypeScript/backend/tests/login/capslock-warning-test.tsnew+78 −0
- Build/Sources/TypeScript/backend/login.ts+1 −0
- Build/Sources/TypeScript/backend/user-pass-login.ts+0 −103
- typo3/sysext/backend/Resources/Private/Templates/Login/ResetPasswordForm.fluid.html+31 −27
- typo3/sysext/backend/Resources/Public/JavaScript/login/capslock-warning.jsnew+19 −0
- typo3/sysext/backend/Resources/Public/JavaScript/login.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/user-pass-login.js+2 −8
Review log 1418
-
Georg Ringer uploaded patch set 1 10/05/26, 20:50
-
Georg Ringer commented on patch set 1 10/05/26, 20:51
This change is ready for review. -
core-ci voted on patch set 1 V +1 10/05/26, 20:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110155
-
Simon Schaufelberger commented on patch set 1 10/05/26, 23:53
the icon is shown immediately but does not disappear when i press the capslock again. somehow it disappears when i doublepress it. that doesn't feel right. -
Simon Schaufelberger commented on patch set 1 10/05/26, 23:54
Reply
tested on Firefox Ubuntu -
Georg Ringer uploaded patch set 2
V +110/10/26, 09:21 -
core-ci voted on patch set 2 V +1 10/10/26, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110783
-
Guido Schmechel commented on patch set 2 CR +1 V +1 10/12/26, 17:19
Technically, it works. The icon itself isn't really my style, but that's just a matter of taste ;-) -
Oli Bartsch uploaded patch set 3
CR +1V +110/20/26, 16:32 -
Oli Bartsch commented on patch set 3 10/20/26, 16:37
The capslock module is now loaded via a side-effect import in `login.ts` (same as `input/clearable`) instead of an `<f:asset.module>` in each template. `login.js` is loaded on every login page anyway: by the `Login` layout, which login providers have to use, and by `ResetPasswordController`. Before this patch the binding came with `user-pass-login.js`. With the per-template asset, an overridden `UserPassLoginForm` or `ResetPasswordForm` would keep the `t3js-capslockwarning` fields but silently lose the warning. That matters more since this goes to 14.3 as well. -
Oli Bartsch uploaded patch set 4 10/20/26, 16:37
-
Oli Bartsch voted on patch set 4 CR +1 V +1 10/20/26, 16:44
-
core-ci voted on patch set 3 V +1 10/20/26, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111887
-
core-ci voted on patch set 4 V +1 10/20/26, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111890
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 10/20/26, 17:43
-
Oli Bartsch voted on patch set 4 CR +2 V +2 10/22/26, 16:35
-
Oli Bartsch merged patch set 5 10/22/26, 16:36