Review TYPO3_4-5 Merged

9639[BUGFIX] Fatal error 't3lib_lock' does not exist

Oliver Hader CR +2 V +2 Easy +4 −0 updated 06/03/13, 20:49

Commit message

The PHP fatal error occurs for the following settings:
$TYPO3_CONF_VARS['SYS']['enableDeprecationLog'] is enabled
$TYPO3_CONF_VARS['BE']['forceCharset'] is not "utf-8" (or empty)
$TYPO3_CONF_VARS['SYS']['enableDeprecationLog'] is set to "file"

Review

  • Code review CR +2
    • Oliver Hader +2
    • Sebastian Michaelsen +1
    • Oliver Klee +1
    • Philipp Gampe +1
  • Verified V +2
    • Oliver Hader +2
    • Philipp Gampe +1

Files 1

Review log 11

  1. Oliver Klee commented on patch set 1 03/16/12, 21:32

    Looks good to me, but someone else must approve
  2. Oliver Klee commented on patch set 2 03/16/12, 21:32

    Looks good to me, but someone else must approve
  3. Oliver Hader commented on patch set 2 03/16/12, 21:32

    Without TRUE as explicit parameter on class_exists()
  4. Oliver Hader uploaded patch set 2 03/16/12, 21:32

  5. Oliver Hader commented on patch set 2 V 0 03/16/12, 21:32

    by team member; Looks good to me, approved
  6. Sebastian Michaelsen commented on patch set 2 03/16/12, 21:32

    Looks good to me, but someone else must approve
  7. Sebastian Fischer commented on patch set 1 03/16/12, 21:32

    Looks good to me, but someone else must approve
  8. Philipp Gampe commented on patch set 1 03/16/12, 21:32

    Verified; Looks good to me, but someone else must approve

    class.t3lib_div.php:6047

    The second parameter of class_exists is per default TRUE, thus this can me omitted.
  9. Philipp Gampe commented on patch set 2 03/16/12, 21:32

    Verified; Looks good to me, but someone else must approve Thanks, reapplying vote.
  10. Wouter Wolters commented on patch set 1 03/16/12, 21:32

    Verified; Looks good to me, but someone else must approve Tested with the given examples.
  11. Oliver Hader merged patch set 2 03/16/12, 21:32