Review main Merged

96394[TASK] Cover forceAbsoluteUrls for f:asset ViewHelpers

Georg Ringer CR +2 V +2 Easy +23 −0 updated 10/06/26, 07:19

Commit message

Assets registered via the AssetCollector (f:asset.css and
f:asset.script) now respect config.forceAbsoluteUrls, as the
AssetRenderer generates URIs with the System Resource API, which
evaluates the frontend URL prefix of the current request.

A previous fix for this issue was reverted, as it rendered file
system paths in the frontend and no tests existed to detect it.

AbsoluteUriPrefixRenderingTest now covers assets referenced by
extension paths and by relative public paths, with and without
config.forceAbsoluteUrls.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Georg Ringer uploaded patch set 1 10/06/26, 04:54

  2. Georg Ringer commented on patch set 1 10/06/26, 04:54

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/06/26, 05:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110176

  4. Josua Vogel voted on patch set 1 CR +1 V +1 10/06/26, 05:21

  5. Benni Mack voted on patch set 1 CR +1 V +1 10/06/26, 06:52

  6. Benni Mack voted on patch set 1 CR +2 10/06/26, 07:19

  7. Benni Mack voted on patch set 1 V +2 10/06/26, 07:19

  8. Benni Mack merged patch set 2 10/06/26, 07:19