Review main Merged

96395[DOCS] Remove the +intl-icu domain suffix from translator docblocks

Lina Wolf CR +2 V +2 Easy +7 −7 updated 10/08/26, 05:37

Commit message

The docblocks of TranslatorInterface and LanguageService tell
developers to add "+intl-icu" to the translation domain to use the ICU
MessageFormat. No code reads this suffix: the label lookup uses the
domain as it is, so a suffixed domain finds no label. Named arguments
select the ICU MessageFormat instead.

Remove the suffix from the parameter descriptions and the example, and
use my_extension as the example extension key.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Lina Wolf uploaded patch set 1 10/06/26, 05:48

  2. core-ci voted on patch set 1 V +1 10/06/26, 05:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110179

  3. Josua Vogel voted on patch set 1 CR +1 V +1 10/06/26, 06:05

  4. Georg Ringer voted on patch set 1 CR +1 V +1 10/06/26, 06:27

  5. Garvin Hicking voted on patch set 1 CR +2 V +2 10/08/26, 05:37

  6. Garvin Hicking merged patch set 2 10/08/26, 05:37