Review main Merged

96398[BUGFIX] Limit Fluid debug output to active admin panel

Georg Ringer CR +2 V +2 Normal +104 −15 updated 10/18/26, 17:00

Commit message

The admin panel's f:render override decided on its own whether to
render debug output, based solely on the stored user setting. The page
cache, however, is only disabled while the admin panel is open and the
preview module is initialized. With the panel closed but the setting
still stored, debug output was rendered into cacheable pages and then
delivered to every visitor.

The preview module now marks the request when it activates Fluid
debugging and disables the cache, and the ViewHelper only renders debug
output for requests carrying that mark.

The new request attribute "admin-panel.fluid.debug" is internal and
not considered public API.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 79

  1. Georg Ringer uploaded patch set 1 10/06/26, 06:45

  2. Georg Ringer commented on patch set 1 10/06/26, 06:45

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/06/26, 06:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110187

  4. Benni Mack commented on patch set 1 CR -1 10/07/26, 13:57

    a) let's use "admin-panel.fluid.debug" b) we should clarify that this new request attribute is "internal"
  5. Georg Ringer uploaded patch set 2 CR -1 V +1 10/10/26, 09:11

  6. core-ci voted on patch set 2 V +1 10/10/26, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110779

  7. Wouter Wolters voted on patch set 2 CR +1 V +1 10/14/26, 16:02

  8. Benni Mack commented on patch set 2 CR +2 V +2 10/18/26, 16:59

    Reply

    Done
  9. Benni Mack merged patch set 3 10/18/26, 17:00