Review main Merged

96402[TASK] Add copy to clipboard button to styleguide code examples

Georg Ringer CR +2 V +2 Normal +227 −4 updated 10/07/26, 14:38

Commit message

The code examples rendered by the styleguide ViewHelpers now provide
a button to copy the shown code to the clipboard, using the existing
typo3-copy-to-clipboard element. The button is placed in a header
row above the code, so it is clearly attached to the code it copies
and does not reduce the width of the code editor.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 810

  1. Georg Ringer uploaded patch set 1 10/06/26, 07:13

  2. Georg Ringer commented on patch set 1 10/06/26, 07:14

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/06/26, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110192

  4. Oli Bartsch uploaded patch set 2 V +1 10/06/26, 07:54

  5. Oli Bartsch commented on patch set 2 CR +1 V +1 10/06/26, 07:55

    Really like this! I just placed the button above the code as I think it looked a bit lost on the right and also shirnked down the code block width. Please check if you like it or revert the patchset :)
  6. core-ci voted on patch set 2 V +1 10/06/26, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110199

  7. Josua Vogel voted on patch set 2 CR +1 V +1 10/07/26, 13:15

  8. Georg Ringer commented on patch set 2 CR +1 V +1 10/07/26, 13:30

    fine for me as well
  9. Georg Ringer voted on patch set 2 CR +2 V +2 10/07/26, 14:38

  10. Georg Ringer merged patch set 3 10/07/26, 14:38