96402[TASK] Add copy to clipboard button to styleguide code examples
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Josua Vogel +1
-
Verified V +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Josua Vogel +1
- core-ci +1 CI
Issues 1
Files 8
- Build/Sources/Sass/module/_styleguide.scss+16 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+3 −0
- typo3/sysext/styleguide/Classes/Service/CodeExampleHeaderRenderer.phpnew+62 −0
- typo3/sysext/styleguide/Classes/ViewHelpers/CodeViewHelper.php+6 −2
- typo3/sysext/styleguide/Classes/ViewHelpers/ExampleViewHelper.php+6 −2
- typo3/sysext/styleguide/Resources/Private/Language/locallang.xlf+6 −0
- typo3/sysext/styleguide/Tests/Functional/ViewHelpers/CodeViewHelperTest.phpnew+64 −0
- typo3/sysext/styleguide/Tests/Functional/ViewHelpers/ExampleViewHelperTest.phpnew+64 −0
Review log 810
-
Georg Ringer uploaded patch set 1 10/06/26, 07:13
-
Georg Ringer commented on patch set 1 10/06/26, 07:14
This change is ready for review. -
core-ci voted on patch set 1 V +1 10/06/26, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110192
-
Oli Bartsch uploaded patch set 2
V +110/06/26, 07:54 -
Oli Bartsch commented on patch set 2 CR +1 V +1 10/06/26, 07:55
Really like this! I just placed the button above the code as I think it looked a bit lost on the right and also shirnked down the code block width. Please check if you like it or revert the patchset :) -
core-ci voted on patch set 2 V +1 10/06/26, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110199
-
Josua Vogel voted on patch set 2 CR +1 V +1 10/07/26, 13:15
-
Georg Ringer commented on patch set 2 CR +1 V +1 10/07/26, 13:30
fine for me as well -
Georg Ringer voted on patch set 2 CR +2 V +2 10/07/26, 14:38
-
Georg Ringer merged patch set 3 10/07/26, 14:38