Review main Merged

96406[BUGFIX] Remove folders deleted inside a recycler folder

Oli Bartsch CR +2 V +2 Easy +17 −6 updated 10/06/26, 10:50

Commit message

Since folders are moved into the nearest recycler folder by
ResourceStorage, the recycler lookup of LocalDriver::deleteFolder()
is only reached for folders the storage decided to remove, which
are folders inside a recycler folder. The driver moved those into
another recycler folder instead, so a folder emptied in a nested
recycler folder by the garbage collection task ended up in an outer
recycler folder again.

The driver now removes the folder, as it already does for files.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Oli Bartsch uploaded patch set 1 10/06/26, 08:21

  2. core-ci voted on patch set 1 V +1 10/06/26, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110208

  3. Benni Mack updated the commit message in patch set 2 V +1 10/06/26, 08:42

  4. core-ci voted on patch set 2 V +1 10/06/26, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110211

  5. Benni Mack voted on patch set 2 CR +1 V +1 10/06/26, 09:12

  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/06/26, 09:37

  7. Oli Bartsch voted on patch set 2 CR +2 V +2 10/06/26, 10:49

  8. Oli Bartsch merged patch set 3 10/06/26, 10:50