Review main Merged

96411[BUGFIX] Respect recycle time and errors in recycler garbage collection

Oli Bartsch CR +2 V +2 Normal +87 −19 updated 10/07/26, 13:10

Commit message

Moving a file into a recycler folder keeps its modification time, so
the garbage collection task removed a file deleted today on its next
run if the file had not changed for the configured number of days.
The time of recycling is now derived from the change time a move
sets on the moved file or folder. Where a driver reports no such
time, the modification time is used as before.

A file or folder that could not be removed, e.g. due to the denied
file extension of a PHP file, aborted the whole run and left the
remaining recycler folders untouched. Such errors are now logged and
the cleanup continues, while the task still reports a failed run.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Josua Vogel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Josua Vogel +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 10/06/26, 11:10

  2. core-ci voted on patch set 1 V +1 10/06/26, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110218

  3. Benni Mack voted on patch set 1 CR +1 V +1 10/06/26, 11:43

  4. Josua Vogel voted on patch set 1 CR +1 V +1 10/07/26, 11:49

  5. Oli Bartsch voted on patch set 1 CR +2 V +2 10/07/26, 13:10

  6. Oli Bartsch merged patch set 2 10/07/26, 13:10