Review main Merged

96417[BUGFIX] Create responses with a text body correctly

Georg Ringer CR +2 V +2 Normal +57 −3 updated 10/12/26, 20:31

Commit message

The constructor of TYPO3\CMS\Core\Http\Response treats a string body as
a stream identifier and opens it with fopen(). Passing the response
text there failed:

The StaticRouteResolver emitted a PHP warning for invalid route
arguments and sent an empty 404 response instead of "Invalid route".
The live search crashed with a ValueError for an empty query instead of
answering with 400.

Both now pass the text in a way that writes it as the response body.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Simon Schaufelberger +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Simon Schaufelberger +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 78

  1. Georg Ringer uploaded patch set 1 10/06/26, 15:08

  2. Georg Ringer commented on patch set 1 10/06/26, 15:10

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/06/26, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110231

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 10/06/26, 20:07

  5. Benni Mack voted on patch set 1 CR +1 V +1 10/12/26, 19:24

  6. Oli Bartsch voted on patch set 1 CR +1 V +1 10/12/26, 19:51

  7. Georg Ringer voted on patch set 1 CR +2 V +2 10/12/26, 20:31

  8. Georg Ringer merged patch set 2 10/12/26, 20:31