Review main Merged

96418[TASK] Update PHPStan to v2.3

Wouter Wolters CR +2 V +2 Easy +17 −15 updated 10/07/26, 10:19

Commit message

Updates the PHPStan development dependency to v2.3
This release contains major performance improvements

See https://phpstan.org/blog/phpstan-2-3-leap-in-performance

Elapsed time: 55 seconds on v2.2
Elapsed time: 40 seconds on v2.3

Update the phpstan/phpstan-phpunit plugin to v2.1

> Build/Scripts/runTests.sh -s composer -- \
      require --dev phpstan/phpstan:^2.3 \
      phpstan/phpstan-phpunit:^2.1
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1215

  1. Wouter Wolters uploaded patch set 1 10/06/26, 16:09

  2. Wouter Wolters updated the commit message in patch set 2 10/06/26, 16:13

  3. core-ci voted on patch set 1 V +1 10/06/26, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110238

  4. core-ci voted on patch set 2 V +1 10/06/26, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110239

  5. Wouter Wolters marked it ready for review 10/06/26, 16:27

  6. Oliver Klee voted on patch set 2 CR +1 V +1 10/06/26, 17:02

  7. Oliver Klee commented on patch set 2 10/06/26, 17:04

    composer.json:126

    There has also been a new release of this package: https://github.com/phpstan/phpstan-phpunit/releases/tag/2.1.0 Should we add this update as well while we're at it?
  8. Wouter Wolters uploaded patch set 3 CR +1 V +1 10/06/26, 18:25

  9. core-ci voted on patch set 3 V +1 10/06/26, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110253

  10. Wouter Wolters commented on patch set 3 10/06/26, 18:36

    composer.json:126 Reply

    Done
  11. Garvin Hicking voted on patch set 3 CR +1 V +1 10/06/26, 18:50

  12. Oliver Klee voted on patch set 3 CR +1 V +1 10/06/26, 18:52

  13. Simon Schaufelberger voted on patch set 3 CR +1 V +1 10/06/26, 19:49

  14. Garvin Hicking voted on patch set 3 CR +2 V +2 10/07/26, 06:24

  15. Garvin Hicking merged patch set 4 10/07/26, 10:19