96419[BUGFIX] Create new inline child with useCombination
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Wouter Wolters +1
- Josua Vogel +1
- Benni Mack +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Georg Ringer +2
- Wouter Wolters +1
- Benni Mack +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1214
-
Georg Ringer uploaded patch set 1 10/06/26, 16:40
-
Georg Ringer commented on patch set 1 10/06/26, 16:41
This change is ready for review. -
core-ci voted on patch set 1 V +1 10/06/26, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110243
-
David Bruchmann commented on patch set 1 10/06/26, 18:10
Thanks Georg, I tested the fix and it works well with the "create new form engine button". The button "create new relation" is still creating a new record when all existing records are already used. It would be acceptable, so I don't know if you want to proceed here - it would probably also require some feedback for the user. -
David Bruchmann voted on patch set 1 V +1 10/06/26, 18:20
-
Georg Ringer commented on patch set 1 11/03/26, 19:44
Reply
Acknowledged -
Georg Ringer uploaded patch set 2
V +111/11/26, 20:29 -
core-ci voted on patch set 2 V +1 11/11/26, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114142
-
Benni Mack voted on patch set 2 CR +1 V +1 11/12/26, 18:38
-
Wouter Wolters voted on patch set 2 CR +1 V +1 11/12/26, 18:49
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/14/26, 20:35
-
Josua Vogel voted on patch set 2 CR +1 11/17/26, 18:57
-
Georg Ringer voted on patch set 2 CR +2 V +2 11/18/26, 21:02
-
Georg Ringer merged patch set 3 11/18/26, 21:02