Review main Merged

96420[BUGFIX] Unify system maintainer check of install tool session

Georg Ringer CR +2 V +2 Normal +61 −4 updated 10/22/26, 20:06

Commit message

The install tool session forwarded from the backend evaluated
`$GLOBALS['TYPO3_CONF_VARS']['SYS']['systemMaintainers']` on its
own and considered every admin a system maintainer if the list
was empty.

`BackendUserAuthentication::isSystemMaintainer()` however only
does this if the setting is not configured at all. An empty list
means that no admin is a system maintainer, which is also what
the install tool writes when the maintainer list is cleared.

The check of the install tool session now follows the same rules.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josua Vogel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Josua Vogel +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 67

  1. Georg Ringer uploaded patch set 1 10/06/26, 16:47

  2. Georg Ringer commented on patch set 1 10/06/26, 16:47

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/06/26, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110244

  4. Josua Vogel voted on patch set 1 CR +1 V +1 10/07/26, 13:32

  5. Benni Mack voted on patch set 1 CR +1 V +1 10/10/26, 06:33

  6. Georg Ringer voted on patch set 1 CR +2 V +2 10/22/26, 20:06

  7. Georg Ringer merged patch set 2 10/22/26, 20:06