Review main Merged

9643[BUGFIX] Fatal error 't3lib_lock' does not exist

Oliver Hader CR +2 V +2 Easy +4 −0 updated 06/03/13, 20:49

Commit message

The PHP fatal error occurs for the following settings:
$TYPO3_CONF_VARS['SYS']['enableDeprecationLog'] is enabled
$TYPO3_CONF_VARS['BE']['forceCharset'] is not "utf-8" (or empty)
$TYPO3_CONF_VARS['SYS']['enableDeprecationLog'] is set to "file"

Review

  • Code review CR +2
    • Oliver Hader +2
    • Oliver Klee +1
    • Tolleiv Nietsch +1
  • Verified V +2
    • Oliver Hader +2
    • Tolleiv Nietsch +1

Files 1

Review log 15

  1. Tolleiv Nietsch uploaded patch set 2 03/16/12, 09:51

  2. Tolleiv Nietsch commented on patch set 2 03/16/12, 09:51

    Verified; Looks good to me, but someone else must approve As suggested by Steffen - the second param wasn't needed
  3. Oliver Klee commented on patch set 1 03/16/12, 09:51

    Looks good to me, but someone else must approve
  4. Oliver Klee commented on patch set 2 03/16/12, 09:51

    Looks good to me, but someone else must approve
  5. Xavier Perseguers commented on patch set 1 03/16/12, 09:51

    Looks good to me, but someone else must approve
  6. Steffen Ritter commented on patch set 1 03/16/12, 09:51

    Looks good to me, approved
  7. Sebastian Fischer commented on patch set 1 03/16/12, 09:51

    Looks good to me, but someone else must approve
  8. Philipp Gampe commented on patch set 1 V 0 03/16/12, 09:51

    Easy test: just set $TYPO3_CONF_VARS['BE']['forceCharset'] = 'test' and remove all typo3conf/temp_* files. Then call frontend or the backend.

    class.t3lib_div.php:5513

    TRUE is the default value for the second parameter, so it should be omitted.
  9. Philipp Gampe commented on patch set 1 03/16/12, 09:51

    No score oops, I verified this on 4-5 only. How do I reproduce this on master? It always gives me the error message about not having the option $TYPO3_CONF_VARS['BE']['forceCharset'] any more.
  10. Philipp Gampe commented on patch set 1 03/16/12, 09:51

    Looks good to me, but someone else must approve
  11. Mr. Jenkins commented on patch set 1 03/16/12, 09:51

  12. Mr. Jenkins commented on patch set 2 03/16/12, 09:51

  13. Wouter Wolters commented on patch set 1 03/16/12, 09:51

    Verified; Looks good to me, but someone else must approve
  14. Oliver Hader commented on patch set 2 V 0 03/16/12, 09:51

    by team member; Looks good to me, approved
  15. Oliver Hader merged patch set 2 03/16/12, 09:51