9643[BUGFIX] Fatal error 't3lib_lock' does not exist
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Oliver Klee +1
- Tolleiv Nietsch +1
-
Verified V +2
- Oliver Hader +2
- Tolleiv Nietsch +1
Files 1
Review log 15
-
Tolleiv Nietsch uploaded patch set 2 03/16/12, 09:51
-
Tolleiv Nietsch commented on patch set 2 03/16/12, 09:51
Verified; Looks good to me, but someone else must approve As suggested by Steffen - the second param wasn't needed -
Oliver Klee commented on patch set 1 03/16/12, 09:51
Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 2 03/16/12, 09:51
Looks good to me, but someone else must approve -
Xavier Perseguers commented on patch set 1 03/16/12, 09:51
Looks good to me, but someone else must approve -
Steffen Ritter commented on patch set 1 03/16/12, 09:51
Looks good to me, approved -
Sebastian Fischer commented on patch set 1 03/16/12, 09:51
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 1 V 0 03/16/12, 09:51
Easy test: just set $TYPO3_CONF_VARS['BE']['forceCharset'] = 'test' and remove all typo3conf/temp_* files. Then call frontend or the backend.class.t3lib_div.php:5513TRUE is the default value for the second parameter, so it should be omitted. -
Philipp Gampe commented on patch set 1 03/16/12, 09:51
No score oops, I verified this on 4-5 only. How do I reproduce this on master? It always gives me the error message about not having the option $TYPO3_CONF_VARS['BE']['forceCharset'] any more. -
Philipp Gampe commented on patch set 1 03/16/12, 09:51
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 03/16/12, 09:51
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3580/ : SUCCESS -
Mr. Jenkins commented on patch set 2 03/16/12, 09:51
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3588/ : SUCCESS -
Wouter Wolters commented on patch set 1 03/16/12, 09:51
Verified; Looks good to me, but someone else must approve -
Oliver Hader commented on patch set 2 V 0 03/16/12, 09:51
by team member; Looks good to me, approved -
Oliver Hader merged patch set 2 03/16/12, 09:51