Review main Merged

96434[DOCS] Clarify arguments of ExpressionBuilder::inSet()

Georg Ringer CR +2 V +2 Easy +24 −9 updated 10/07/26, 16:29

Commit message

The docblocks of inSet() and notInSet() did not tell which argument
is the comma-separated list and which is the value searched for. As
the order is the reverse of MySQL's FIND_IN_SET(needle, haystack),
the methods were easily confused with in().

The docblocks now name the field as haystack and the value as
needle, give an example, state that the value is not quoted
automatically and point to in() for the opposite use case.

The SQLite placeholder exception of notInSet() now names the right
method.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Josua Vogel +1
    • Ravi Sachaniya +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Josua Vogel +1
    • Ravi Sachaniya +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Georg Ringer uploaded patch set 1 10/06/26, 20:43

  2. Georg Ringer commented on patch set 1 10/06/26, 20:44

    This change is ready for review.
  3. Josua Vogel voted on patch set 1 CR +1 V +1 10/07/26, 05:35

  4. core-ci voted on patch set 1 V +1 10/07/26, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110279

  5. Ravi Sachaniya voted on patch set 1 CR +1 V +1 10/07/26, 09:36

  6. Oliver Klee voted on patch set 1 CR +1 V +1 10/07/26, 09:49

  7. Benni Mack voted on patch set 1 CR +2 V +2 10/07/26, 16:29

  8. Benni Mack merged patch set 2 10/07/26, 16:29