Review main Merged

96435[BUGFIX] Show exception example inside the styleguide module

Oli Bartsch CR +2 V +2 Normal +84 −3 updated 10/07/26, 15:44

Commit message

The exception component of EXT:styleguide threw a real exception,
which replaced the whole module with the exception page and left
no navigation to get back.

The component view now loads the action throwing the exception in
an iframe. The configured exception handler still renders the page
including its inline JavaScript, but the module stays intact.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Wouter Wolters +1
    • Garvin Hicking +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Wouter Wolters +1
    • Garvin Hicking +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1013

  1. Oli Bartsch uploaded patch set 1 10/06/26, 20:52

  2. Oli Bartsch rebased onto patch set 2 10/06/26, 21:20

  3. Garvin Hicking commented on patch set 2 10/07/26, 05:13

    Hhhhm. Not a fan: modifies the "actual" exception so that it doesn't really simulate the reality of an exception and might lag the actual exception handler or we forget. Also it increases complexity a lot. And I think its totally fine to not have the module cintent when testing the exception, as it can be restored through the left hand menu, and its an exception to test this ;) Not blocking.
  4. Oli Bartsch uploaded patch set 3 10/07/26, 06:29

  5. Oli Bartsch commented on patch set 3 10/07/26, 06:34

    Reply

    I dropped the custom renderer. The component now loads an action in an iframe that throws the same StatusException as before. So the real, configured exception handler renders it (inline JS, status headers, logging), there's nothing to drift, and the diff is basically a template plus one action. The only change is that the module navigation survives.
  6. Garvin Hicking commented on patch set 3 CR +1 V +1 10/07/26, 06:58

    Yes, this works for me 😊
  7. core-ci voted on patch set 3 V +1 10/07/26, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110288

  8. core-ci voted on patch set 1 V -1 10/07/26, 09:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110280

  9. core-ci voted on patch set 2 V +1 10/07/26, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110281

  10. Josua Vogel voted on patch set 3 CR +1 V +1 10/07/26, 13:42

  11. Wouter Wolters voted on patch set 3 CR +1 V +1 10/07/26, 15:27

  12. Oli Bartsch voted on patch set 3 CR +2 V +2 10/07/26, 15:44

  13. Oli Bartsch merged patch set 4 10/07/26, 15:44