96436[BUGFIX] Keep translated relations on import
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Wolfgang Klinger +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Kott +2
- Wolfgang Klinger +1
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 11
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php+71 −2
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+10 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/NewRecordWithoutResolvablePidTest.phpnew+97 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/DataSet/ImportTranslationWithoutPointers.csvnew+6 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/DataSet/restoreTranslationNChildPointersWExclude.csvnew+12 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/ActionTest.php+7 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/AbstractActionTestCase.php+31 −0
- typo3/sysext/impexp/Classes/Import.php+38 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseAssertions/importMultilingualTtContentWithImageInExcludedField.csvnew+14 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-multilingual-with-image.xmlnew+866 −0
- typo3/sysext/impexp/Tests/Functional/Import/MultilingualPagesAndTtContentTest.php+21 −0
Review log 67
-
Benjamin Kott uploaded patch set 1 10/06/26, 23:24
-
Wolfgang Klinger commented on patch set 1 CR +1 V +1 10/07/26, 08:24
Verified with real data on top of the included tests. One question: why not 13.4? The TypeError exists there too and the introduction package still targets ^13.4. -
core-ci voted on patch set 1 V +1 10/07/26, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110282
-
Benni Mack voted on patch set 1 CR +1 V +1 10/09/26, 20:08
-
Benni Mack commented on patch set 1 10/10/26, 06:26
Reply
Although I completely understand the reasoning behind it, I'm very very reluctant to backport DataHandler changes nowadays to the "critical bugfixes only" branch. Various changes now made it to 14.3 only in this area, so I can only stress all of you enough to upgrade to v14 -
Benjamin Kott voted on patch set 1 CR +2 V +2 10/10/26, 09:52
-
Benjamin Kott merged patch set 2 10/10/26, 10:37