96440[BUGFIX] Show route decorations in the slug preview of pages
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Wouter Wolters +1
-
Verified V +2 Done
- Oli Bartsch +2
- Wouter Wolters +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/backend/form-engine/element/slug-element.ts+2 −2
- typo3/sysext/backend/Classes/Controller/FormSlugAjaxController.php2+51 −2
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/slug-element.js+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/Fixtures/FormSlugAjaxControllerWorkspace.csvnew+6 −0
- typo3/sysext/backend/Tests/Functional/Controller/FormSlugAjaxControllerTest.phpnew+245 −0
Review log 1317
-
Benni Mack uploaded patch set 1 10/07/26, 06:53
-
core-ci voted on patch set 1 V +1 10/07/26, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110291
-
Benni Mack marked it ready for review 10/07/26, 16:09
-
Wouter Wolters commented on patch set 1 CR +1 V +1 10/07/26, 16:19
Only thing I spotted was a missingtest for the not "pages" table previewpath as the test only uses tableName pages. -
Oli Bartsch uploaded patch set 2
CR +1V +110/07/26, 20:14 -
Oli Bartsch voted on patch set 2 CR +1 V +1 10/07/26, 20:15
-
core-ci voted on patch set 2 V +1 10/07/26, 20:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110397
-
Markus Klein commented on patch set 2 10/08/26, 07:24
FormSlugAjaxController.php:171can we document, why this is needed please? -
Benni Mack commented on patch set 3
CR +1V +110/20/26, 15:44Published edit on patch set 2. -
Benni Mack commented on patch set 3 10/20/26, 15:44
FormSlugAjaxController.php:171ReplyDone -
core-ci voted on patch set 3 V -1 10/20/26, 15:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111875
-
Benni Mack rebased onto patch set 4
V -110/23/26, 05:43 -
core-ci voted on patch set 4 V +1 10/23/26, 05:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112215
-
Oli Bartsch voted on patch set 4 CR +1 V +1 10/28/26, 17:26
-
Wouter Wolters voted on patch set 4 CR +1 V +1 10/28/26, 17:27
-
Oli Bartsch voted on patch set 4 CR +2 V +2 10/28/26, 18:25
-
Oli Bartsch merged patch set 5 10/28/26, 18:25