Review main Merged

96440[BUGFIX] Show route decorations in the slug preview of pages

Benni Mack CR +2 V +2 Hard +305 −5 updated 10/28/26, 18:25

Commit message

The slug field of a page previewed the URL as language base plus
slug, so a suffix added by a "PageType" route enhancer (e.g. ".html")
was missing from the "this page will look like" message.

The slug AJAX endpoint now generates the preview path through the
router of the site, passing the full page record (including unsaved
form values, the workspace version and the overlay shape for
translations). Decorators, "limitToPages" conditions and the "index"
handling of the root page are applied the same way as in the frontend.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1317

  1. Benni Mack uploaded patch set 1 10/07/26, 06:53

  2. core-ci voted on patch set 1 V +1 10/07/26, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110291

  3. Benni Mack marked it ready for review 10/07/26, 16:09

  4. Wouter Wolters commented on patch set 1 CR +1 V +1 10/07/26, 16:19

    Only thing I spotted was a missingtest for the not "pages" table previewpath as the test only uses tableName pages.
  5. Oli Bartsch uploaded patch set 2 CR +1 V +1 10/07/26, 20:14

  6. Oli Bartsch voted on patch set 2 CR +1 V +1 10/07/26, 20:15

  7. core-ci voted on patch set 2 V +1 10/07/26, 20:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110397

  8. Markus Klein commented on patch set 2 10/08/26, 07:24

    FormSlugAjaxController.php:171

    can we document, why this is needed please?
  9. Benni Mack commented on patch set 3 CR +1 V +1 10/20/26, 15:44

    Published edit on patch set 2.
  10. Benni Mack commented on patch set 3 10/20/26, 15:44

    FormSlugAjaxController.php:171 Reply

    Done
  11. core-ci voted on patch set 3 V -1 10/20/26, 15:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111875

  12. Benni Mack rebased onto patch set 4 V -1 10/23/26, 05:43

  13. core-ci voted on patch set 4 V +1 10/23/26, 05:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112215

  14. Oli Bartsch voted on patch set 4 CR +1 V +1 10/28/26, 17:26

  15. Wouter Wolters voted on patch set 4 CR +1 V +1 10/28/26, 17:27

  16. Oli Bartsch voted on patch set 4 CR +2 V +2 10/28/26, 18:25

  17. Oli Bartsch merged patch set 5 10/28/26, 18:25