Review main Merged

96454[BUGFIX] Hide l10n_mode=exclude fields in translations with hideDiff

Benni Mack CR +2 V +2 Normal +126 −3 updated 10/07/26, 15:15

Commit message

Fields configured with l10n_mode=exclude were only hidden in
translated records when l10n_display was empty. Any other value,
including "hideDiff", kept the field visible and editable, although
DataHandler overwrites its value from the default language record
on save.

Only "defaultAsReadonly" is meant to show an excluded field in a
translation, so FormEngine and the VisibleSchemaFieldsCollector now
check for that option explicitly.

EXT:styleguide gains examples for both combinations, covered by an
e2e test.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 67

  1. Benni Mack uploaded patch set 1 10/07/26, 09:42

  2. Benni Mack marked it ready for review 10/07/26, 09:43

  3. core-ci voted on patch set 1 V +1 10/07/26, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110298

  4. Georg Ringer voted on patch set 1 CR +1 V +1 10/07/26, 14:34

  5. Wouter Wolters voted on patch set 1 CR +1 V +1 10/07/26, 15:12

  6. Benni Mack voted on patch set 1 CR +2 V +2 10/07/26, 15:15

  7. Benni Mack merged patch set 2 10/07/26, 15:15