Review main Work in progress Quiet

96458[WIP][TASK] Cover sync of excluded inline children

Benjamin Kott CR 0 V -1 Normal +218 −0 updated 10/07/26, 12:58

Commit message

A field declared l10n_mode=exclude "is excluded from the translation
editing - means, it always has the same value as the default
translation", as FieldTranslationBehaviour::Excluded puts it. Where
that field holds child records, localizing the parent gives the
translation children of its own, because a child points at its parent
by uid. Those children hang off a field the translation form does not
show, so only the DataHandler can keep them equal to the default
language.

The functional test added here drives that the way FormEngine does
when an editor opens the record of the default language and saves: the
data map carries the parent with the list of its children, and the
changed children beside it. It covers four operations on the default
language - localizing, changing a child, removing one and reordering
them - and asserts that the translation carries the result of each.

Two of the four fail against main today. Reordering reaches the
translation, and so do the children a fresh localization creates. A
changed value and a removed child do not: the translation keeps what
it received when it was created, and no backend form offers it for
correction.

This is the behaviour #89271 reported in 2019 and analysed as the
DataMapProcessor regenerating the children of a translation before the
changed child of the default language is persisted. #88452 and #98050
describe neighbouring symptoms. The test carries no fix, so it is red
on purpose and states what a fix has to make green.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/58/96458/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/58/96458/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Relation chain 2

  1. main 96459[WIP][BUGFIX] Synchronize children of excluded relations Based on this change Work in progress Merge conflict Benjamin Kott CR 0 V 0 Hard +739 −137
  2. 96458 [WIP][TASK] Cover sync of excluded inline children This change

Files 2

Review log 12

  1. Benjamin Kott uploaded patch set 1 10/07/26, 12:45

  2. core-ci voted on patch set 1 V -1 10/07/26, 12:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110310