Review main Merged

96480[SECURITY] Respect saveToFileMount of form uploads

Josua Vogel CR +2 V +2 Hard +228 −215 updated 10/13/26, 09:31

Commit message

The upload folder of a FileUpload element was resolved in
initializeFormElement(), which runs before the element's own
properties are applied. Only the prototype default was taken
into account, so saveToFileMount set per form or element was
ignored.

The folder is now resolved at runtime in
PropertyMappingConfiguration, where the properties of the form
definition are available.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Albrecht Köhnlein +1
    • Elias Häußler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Albrecht Köhnlein +1
    • Elias Häußler +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1723

  1. Josua Vogel uploaded patch set 1 10/07/26, 14:01

  2. Josua Vogel updated the commit message in patch set 2 10/07/26, 14:03

  3. core-ci voted on patch set 2 V +1 10/07/26, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110334

  4. core-ci voted on patch set 1 V +1 10/07/26, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110333

  5. Albrecht Köhnlein commented on patch set 2 10/08/26, 17:43

    Thanks!

    PropertyMappingConfigurationTest.php:52

    Looks to me like we don't need this and the dataset file. Storage "1" seems to be available in tests without this, too.
  6. Josua Vogel uploaded patch set 3 V +1 10/09/26, 06:59

  7. Josua Vogel commented on patch set 3 10/09/26, 06:59

    PropertyMappingConfigurationTest.php:52 Reply

    Yes, thx!
  8. core-ci voted on patch set 3 V -1 10/09/26, 07:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110555

  9. Albrecht Köhnlein rebased onto patch set 4 V -1 10/09/26, 08:34

  10. Albrecht Köhnlein voted on patch set 4 CR +1 V +1 10/09/26, 08:35

  11. core-ci voted on patch set 4 V +1 10/09/26, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110564

  12. Josua Vogel uploaded patch set 5 CR +1 V +1 10/12/26, 08:54

  13. core-ci voted on patch set 5 V +1 10/12/26, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110895

  14. Albrecht Köhnlein voted on patch set 5 CR +1 V +1 10/12/26, 09:25

  15. Benni Mack commented on patch set 5 CR -1 10/12/26, 10:43

    I do need to check something, hold on.
  16. Elias Häußler rebased onto patch set 6 CR +1 V +1 10/13/26, 09:11

  17. Benni Mack commented on patch set 6 10/13/26, 09:14

    Reply

    Done
  18. Elias Häußler voted on patch set 6 CR +1 V +1 10/13/26, 09:15

  19. core-ci voted on patch set 6 V +1 10/13/26, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110994

  20. Albrecht Köhnlein voted on patch set 6 CR +1 V +1 10/13/26, 09:26

  21. Benni Mack voted on patch set 6 CR +2 V +2 10/13/26, 09:27

  22. Benni Mack merged patch set 7 10/13/26, 09:27

  23. Benni Mack wrote 10/13/26, 09:31

    Topic set to security