96480[SECURITY] Respect saveToFileMount of form uploads
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Albrecht Köhnlein +1
- Elias Häußler +1
-
Verified V +2 Done
- Benni Mack +2
- Albrecht Köhnlein +1
- Elias Häußler +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/form/Classes/Domain/Model/FormElements/FileUpload.php+4 −56
- typo3/sysext/form/Classes/Mvc/Property/PropertyMappingConfiguration.php+52 −0
- typo3/sysext/form/Tests/Functional/Mvc/Property/PropertyMappingConfigurationTest.php2new+172 −0
- typo3/sysext/form/Tests/Unit/Domain/FormElements/FileUploadTest.php+0 −159
Review log 1723
-
Josua Vogel uploaded patch set 1 10/07/26, 14:01
-
Josua Vogel updated the commit message in patch set 2 10/07/26, 14:03
-
core-ci voted on patch set 2 V +1 10/07/26, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110334
-
core-ci voted on patch set 1 V +1 10/07/26, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110333
-
Albrecht Köhnlein commented on patch set 2 10/08/26, 17:43
Thanks!PropertyMappingConfigurationTest.php:52Looks to me like we don't need this and the dataset file. Storage "1" seems to be available in tests without this, too. -
Josua Vogel uploaded patch set 3
V +110/09/26, 06:59 -
Josua Vogel commented on patch set 3 10/09/26, 06:59
PropertyMappingConfigurationTest.php:52ReplyYes, thx! -
core-ci voted on patch set 3 V -1 10/09/26, 07:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110555
-
Albrecht Köhnlein rebased onto patch set 4
V -110/09/26, 08:34 -
Albrecht Köhnlein voted on patch set 4 CR +1 V +1 10/09/26, 08:35
-
core-ci voted on patch set 4 V +1 10/09/26, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110564
-
Josua Vogel uploaded patch set 5
CR +1V +110/12/26, 08:54 -
core-ci voted on patch set 5 V +1 10/12/26, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110895
-
Albrecht Köhnlein voted on patch set 5 CR +1 V +1 10/12/26, 09:25
-
Benni Mack commented on patch set 5 CR -1 10/12/26, 10:43
I do need to check something, hold on. -
Elias Häußler rebased onto patch set 6
CR +1V +110/13/26, 09:11 -
Benni Mack commented on patch set 6 10/13/26, 09:14
Reply
Done -
Elias Häußler voted on patch set 6 CR +1 V +1 10/13/26, 09:15
-
core-ci voted on patch set 6 V +1 10/13/26, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110994
-
Albrecht Köhnlein voted on patch set 6 CR +1 V +1 10/13/26, 09:26
-
Benni Mack voted on patch set 6 CR +2 V +2 10/13/26, 09:27
-
Benni Mack merged patch set 7 10/13/26, 09:27
-
Benni Mack wrote 10/13/26, 09:31
Topic set to security