Review 14.3 Merged

96486[BUGFIX] List unselected invalid site sets

Benjamin Franzke CR +2 V +2 Normal +116 −5 updated 10/14/26, 11:52

Commit message

Site sets that fail to load, for example because a setting definition
lacks a label, were only listed in the "Sets" field of a site once they
had been selected. An integrator adding a new, broken set therefore got
no hint why it did not show up.

All invalid sets are now listed below a separate "Invalid site sets"
group, using the same error label as selected invalid sets. A flash
message is still only shown for invalid sets the site depends on.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 46

  1. Benjamin Franzke commented on patch set 1 10/07/26, 14:50

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/Site/TcaSiteSetCollector.php
  2. Benjamin Franzke uploaded patch set 2 10/07/26, 14:53

  3. Benjamin Franzke commented on patch set 2 CR +2 V +2 10/07/26, 14:55

    This change is ready for review.
  4. core-ci voted on patch set 1 V -1 10/07/26, 15:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110344

  5. core-ci voted on patch set 2 V +1 10/07/26, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110345

  6. Benjamin Franzke merged patch set 3 10/14/26, 11:52