Review main Merged

96505[BUGFIX] Validate slug field after the proposal has been applied

Georg Ringer CR +2 V +2 Easy +44 −6 updated 11/10/26, 05:31

Commit message

The slug element dispatched the "change" event before the new
proposal was written into its fields. FormEngine validation therefore
checked the outdated value, so a required slug field stayed marked as
invalid, also after clicking "Recalculate URL segment".

For generated proposals (automatic or recalculated), the proposal is
now applied first and the event dispatched afterwards, also if only the
visible input differs from the proposal. Manually entered slugs no
longer dispatch the event, as they are already validated while typing.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1320

  1. Georg Ringer uploaded patch set 1 10/07/26, 19:31

  2. Georg Ringer commented on patch set 1 10/07/26, 19:32

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/07/26, 19:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110393

  4. Georg Ringer uploaded patch set 2 V +1 10/09/26, 10:47

  5. core-ci voted on patch set 2 V -1 10/09/26, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110588

  6. Georg Ringer rebased onto patch set 3 V -1 10/09/26, 16:16

  7. Benni Mack updated the commit message in patch set 4 10/09/26, 16:16

  8. core-ci voted on patch set 3 V +1 10/09/26, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110626

  9. core-ci voted on patch set 4 V +1 10/09/26, 16:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110627

  10. Benni Mack voted on patch set 4 CR +1 V +1 10/09/26, 17:00

  11. Georg Ringer uploaded patch set 5 CR +1 V +1 11/09/26, 20:08

  12. core-ci voted on patch set 5 V +1 11/09/26, 20:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113775

  13. Georg Ringer rebased onto patch set 6 V +1 11/09/26, 20:39

  14. core-ci voted on patch set 6 V +1 11/09/26, 20:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113783

  15. Oli Bartsch uploaded patch set 7 V +1 11/09/26, 21:43

  16. Oli Bartsch commented on patch set 7 CR +1 V +1 11/09/26, 21:44

    The slug element now dispatches the "change" event only when the proposal comes from AUTO or RECREATE mode, after the proposal has been written to the read-only, hidden and visible fields. In MANUAL mode no event is dispatched, so FormEngine validation no longer overwrites the sanitized proposal in the hidden field with the raw input. Typing is still validated by the existing input listener. The dispatch check now also compares the visible input with the proposal, not just the hidden field. Without that, an input cleared and then recalculated within the debounce window stayed marked as invalid.
  17. core-ci voted on patch set 7 V +1 11/09/26, 21:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113805

  18. Benni Mack voted on patch set 7 CR +1 V +1 11/09/26, 21:58

  19. Georg Ringer voted on patch set 7 CR +2 V +2 11/09/26, 22:04

  20. Benni Mack merged patch set 8 11/10/26, 05:31