96506[BUGFIX] Prevent parent loops in category tree
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Wouter Wolters +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Wouter Wolters +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Tests/Functional/Form/Fixtures/CategoryGrandchild.csvnew+3 −0
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaCategoryTest.php+174 −0
- typo3/sysext/core/Classes/Tree/TableConfiguration/DatabaseTreeDataProvider.php2+84 −0
- typo3/sysext/core/Classes/Tree/TableConfiguration/TreeDataProviderFactory.php+7 −2
- typo3/sysext/core/Tests/Unit/Tree/TableConfiguration/TreeDataProviderFactoryTest.php+28 −0
Review log 1520
-
Georg Ringer uploaded patch set 1 10/07/26, 19:41
-
Georg Ringer commented on patch set 1 10/07/26, 19:41
This change is ready for review. -
core-ci voted on patch set 1 V +1 10/07/26, 19:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110395
-
Wouter Wolters commented on patch set 1 10/07/26, 19:50
DatabaseTreeDataProvider.php:228Can we use strict mode here with setting 3rd param to true? Same below in the while loop -
Oli Bartsch uploaded patch set 2
V +110/26/26, 10:58 -
Oli Bartsch commented on patch set 2 CR +1 V +1 10/26/26, 11:03
DatabaseTreeDataProvider.php:228ReplyDone -
core-ci voted on patch set 2 V -1 10/26/26, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112594
-
Oli Bartsch rebased onto patch set 3
CR +1V +110/26/26, 21:27 -
core-ci voted on patch set 3 V +1 10/26/26, 21:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112616
-
Oli Bartsch voted on patch set 3 CR +1 V +1 10/26/26, 22:23
-
Simon Schaufelberger voted on patch set 3 CR +1 10/27/26, 00:32
-
Oli Bartsch rebased onto patch set 4
CR +1V +111/09/26, 20:58 -
core-ci voted on patch set 4 V +1 11/09/26, 21:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113789
-
Benni Mack uploaded patch set 5
V +111/12/26, 10:52 -
core-ci voted on patch set 5 V +1 11/12/26, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114179
-
Oliver Klee voted on patch set 5 V +1 11/12/26, 11:08
-
Benni Mack voted on patch set 5 CR +1 V +1 11/12/26, 11:52
-
Wouter Wolters voted on patch set 5 CR +1 V +1 11/12/26, 18:43
-
Benni Mack voted on patch set 5 CR +2 V +2 11/12/26, 19:13
-
Benni Mack merged patch set 6 11/12/26, 19:13