Review main Merged

96507[BUGFIX] Try next route on invalid route parameter

Georg Ringer CR +2 V +2 Easy +34 −1 updated 10/09/26, 17:47

Commit message

When generating a page URL, a route whose parameter does not match its
requirement, e.g. an empty value for "{pos}", made Symfony throw an
InvalidParameterException that was not caught. URL generation failed
instead of falling back to the next route candidate, which is already
done for missing mandatory parameters.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josua Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Georg Ringer uploaded patch set 1 10/07/26, 19:50

  2. Georg Ringer commented on patch set 1 10/07/26, 19:50

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/07/26, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110396

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 10/08/26, 00:18

  5. Josua Vogel voted on patch set 1 CR +1 10/08/26, 11:39

  6. Oliver Klee voted on patch set 1 V +1 10/08/26, 12:38

  7. Benni Mack voted on patch set 1 CR +2 V +2 10/09/26, 17:47

  8. Benni Mack merged patch set 2 10/09/26, 17:47