Review 14.3 Merged

96508[BUGFIX] Show stored MM relations in record history diff

Benni Mack CR +2 V +2 Easy +45 −0 updated 10/07/26, 20:51

Commit message

The history diff resolved MM relation fields through
BackendUtility::getProcessedValue() with the record uid. For MM
fields this reads the current rows of the MM table and ignores the
uid list stored in the history entry, so every entry showed the
current relations and the diff stayed empty.

The controller now resolves the stored uid list itself, so old and
new relations are shown and diffed as recorded.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 710

  1. Benni Mack commented on patch set 1 10/07/26, 20:19

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Tests/Functional/Controller/ContentElement/ElementHistoryControllerTest.php
  2. Benni Mack commented on patch set 2 10/07/26, 20:20

    Published edit on patch set 1.
  3. Benni Mack commented on patch set 3 10/07/26, 20:20

    Published edit on patch set 2.
  4. Benni Mack commented on patch set 4 10/07/26, 20:21

    Published edit on patch set 3.
  5. Benni Mack marked it ready for review 10/07/26, 20:21

  6. core-ci voted on patch set 1 V -1 10/07/26, 20:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110399

  7. core-ci voted on patch set 4 V +1 10/07/26, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110403

  8. core-ci voted on patch set 2 V -1 10/07/26, 20:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110400

  9. Benni Mack voted on patch set 4 CR +2 V +2 10/07/26, 20:51

  10. Benni Mack merged patch set 5 10/07/26, 20:51