Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Ready for review

96511[BUGFIX] Validate inherited value of required placeholder fields

Georg Ringer CR 0 V 0 Normal +85 −5 updated 11/11/26, 12:03

Commit message

A required field with mode "useOrOverridePlaceholder" could not be
saved as long as the inherited value was used, e.g. the alternative
text of a file reference that comes from the file metadata. The
client-side validation checked the hidden, empty override field
instead of the value that is actually used.

As long as the value is not overridden, the validation now checks
the inherited value. If none is available, the field is still
reported as missing. Toggling the override checkbox validates the
field again right away.

The field "input_4" of the styleguide table "tx_styleguide_required"
shows this configuration.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/11/96511/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/11/96511/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 1

Files 6

Review log 47

  1. Georg Ringer uploaded patch set 1 10/07/26, 20:43

  2. Georg Ringer commented on patch set 1 10/07/26, 20:43

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/07/26, 20:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110412

  4. Georg Ringer rebased onto patch set 2 V +1 10/10/26, 09:47

  5. core-ci voted on patch set 2 V +1 10/10/26, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110784

  6. Benni Mack uploaded patch set 3 V +1 11/11/26, 11:51

  7. core-ci voted on patch set 3 V +1 11/11/26, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114068