96513[FEATURE] Suggest CSS classes in link browser
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/backend/Classes/Controller/AbstractLinkBrowserController.php+45 −2
- typo3/sysext/backend/Tests/Functional/Controller/LinkBrowserControllerTest.phpnew+99 −0
- typo3/sysext/backend/Tests/Unit/Controller/AbstractLinkBrowserControllerTest.php+139 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-98074-SuggestCssClassesInLinkBrowser.rstnew+64 −0
Review log 79
-
Georg Ringer uploaded patch set 1 10/07/26, 21:01
-
Georg Ringer commented on patch set 1 10/07/26, 21:02
This change is ready for review. -
core-ci voted on patch set 1 V +1 10/07/26, 21:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110415
-
Oli Bartsch uploaded patch set 2
V +110/07/26, 21:40 -
core-ci voted on patch set 2 V +1 10/07/26, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110419
-
Oli Bartsch commented on patch set 2 CR +1 V +1 10/07/26, 21:53
Hey, I pushed one fix: handler-specific cssClass.items were resolved in initVariables(), before the displayed handler is known. When an existing link was opened from FormEngine (no act), e.g. an https:// link, the class field showed the page/global list instead of the url list. Resolution now happens in renderLinkAttributeFields(). cssClass.default/target.default have the same timing issue since #107081; I've fixed that separately: https://review.typo3.org/c/Packages/TYPO3.CMS/+/96514 -
Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/08/26, 00:15
-
Benni Mack voted on patch set 2 CR +2 V +2 10/09/26, 19:26
-
Benni Mack merged patch set 3 10/09/26, 19:26