Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
96525[!!!][TASK] Unify record title resolution
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 6
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/25/96525/6 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/25/96525/6 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 2
Files 14
- typo3/sysext/backend/Classes/Configuration/TCA/UserFunctions.php+16 −23
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRecordTitle.php+20 −347
- typo3/sysext/backend/Classes/Record/RecordTitleResolver.phpnew+197 −0
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+45 −84
- typo3/sysext/backend/Tests/Functional/Configuration/TCA/UserFunctionsTest.phpnew+110 −0
- typo3/sysext/backend/Tests/Functional/Form/Fixtures/FormDataProviderPages.csv+2 −1
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/FormDataProviderTest.php+46 −0
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaRecordTitleTest.php+205 −16
- typo3/sysext/backend/Tests/Functional/Record/RecordTitleResolverTest.phpnew+316 −0
- typo3/sysext/backend/Tests/Functional/Utility/BackendUtilityTest.php+106 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaRecordTitleTest.phpdeleted+0 −1079
- typo3/sysext/core/Documentation/Changelog/15.0/Breaking-110953-RecordTitleResolutionInFormEngine.rst3new+149 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Important-110953-UnifiedRecordTitleResolution.rstnew+90 −0
- typo3/sysext/linkvalidator/Tests/Functional/Fixtures/expected_link_with_page_ce.csv+1 −1
Review log 1117
-
Oli Bartsch uploaded patch set 1 10/08/26, 09:44
-
core-ci voted on patch set 1 V +1 10/08/26, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110475
-
Mathias Brodala commented on patch set 1 10/08/26, 10:03
-
Oli Bartsch uploaded patch set 2
V +110/08/26, 11:46 -
Oli Bartsch commented on patch set 1 10/08/26, 11:48
Breaking-110953-RecordTitleResolutionInFormEngine.rst:111ReplyThanks. The [0] ??... ?? chain doesn't work for string values: 'uri'[0] is 'u', not null, so ?? never falls back. A version check alone isn't enough either, because on v14 label_userFunc already receives the raw row outside FormEngine, e.g. in the list module. I've changed the example to keep the is_array() check and put it behind a Typo3Version check, which gives the marker for dropping the legacy code. Hope that's fine for you. -
core-ci voted on patch set 2 V +1 10/08/26, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110485
-
Mathias Brodala commented on patch set 2 10/08/26, 12:44
Breaking-110953-RecordTitleResolutionInFormEngine.rst:111ReplyThanks for the heads up with the PHP string character lookup. 👍 -
Oli Bartsch rebased onto patch set 3
V +110/19/26, 09:29 -
core-ci voted on patch set 3 V +1 10/19/26, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111611
-
Oli Bartsch uploaded patch set 4
V +110/24/26, 20:43 -
core-ci voted on patch set 4 V +1 10/24/26, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112441
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 10/25/26, 09:25
-
Oliver Klee voted on patch set 4 V +1 10/25/26, 13:08
-
Oli Bartsch uploaded patch set 5
CR +1V +111/01/26, 15:39 -
core-ci voted on patch set 5 V +1 11/01/26, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113023
-
Oli Bartsch uploaded patch set 6
V +111/01/26, 22:14 -
core-ci voted on patch set 6 V +1 11/01/26, 22:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113048
Breaking-110953-RecordTitleResolutionInFormEngine.rst:111