Review 14.3 Merged

96526[BUGFIX] Cap size measurements at PHP_INT_MAX

Garvin Hicking CR +2 V +2 Easy +5 −1 updated 10/08/26, 11:01

Commit message

GeneralUtility::getBytesFromSizeMeasurement() calculates with
floats and casts the result to int. Values exceeding PHP_INT_MAX,
e.g. "1e20G", wrapped around to arbitrary numbers and triggered a
warning on PHP 8.5.

The result is now capped at PHP_INT_MAX, so a huge limit stays a
huge limit instead of turning into a random or zero value.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Garvin Hicking commented on patch set 1 10/08/26, 10:00

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/08/26, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110477

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 10/08/26, 11:00

  4. Garvin Hicking merged patch set 2 10/08/26, 11:01