Review main Merged

96529[BUGFIX] Stop cyclic relations in record titles

Oli Bartsch CR +2 V +2 Normal +66 −21 updated 10/27/26, 20:59

Commit message

If the label of a record is a relation to a record, whose label is
a relation back to the first record, resolving the record title
recursed until the memory limit was reached.

Records, whose relations are currently resolved, are now shown by
their uid only, as it is done for missing records.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Simon Schaufelberger +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1721

  1. Oli Bartsch uploaded patch set 1 10/08/26, 10:38

  2. core-ci voted on patch set 1 V +1 10/08/26, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110481

  3. Oliver Klee voted on patch set 1 V +1 10/08/26, 12:38

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 10/08/26, 13:20

  5. Wouter Wolters voted on patch set 1 CR +1 V +1 10/08/26, 19:27

  6. Guido Schmechel voted on patch set 1 CR +1 V +1 10/17/26, 10:52

  7. Benni Mack commented on patch set 1 CR -1 10/17/26, 11:42

    BackendUtility.php:73

    we tried for years to remove state in classes - this way, we can never use this code across multiple processes (e.g. worker mode for FrankenPHP). We really try to avoid such things in new code.
  8. Oli Bartsch uploaded patch set 2 CR +1 V +1 10/17/26, 15:27

  9. Oli Bartsch commented on patch set 2 10/17/26, 15:29

    BackendUtility.php:73 Reply

    the static state is gone. The records currently being resolved are now passed down as an argument.
  10. core-ci voted on patch set 2 V -1 10/17/26, 15:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111471

  11. Oli Bartsch rebased onto patch set 3 V -1 10/19/26, 08:55

  12. core-ci voted on patch set 3 V +1 10/19/26, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111606

  13. Oli Bartsch uploaded patch set 4 V +1 10/24/26, 20:56

  14. Oli Bartsch commented on patch set 4 10/24/26, 20:56

    BackendUtility.php:73 Reply

    Can you check again please
  15. core-ci voted on patch set 4 V +1 10/24/26, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112443

  16. Benni Mack commented on patch set 4 V +1 10/25/26, 11:56

    BackendUtility.php:73 Reply

    Done
  17. Benni Mack voted on patch set 4 CR +1 10/25/26, 12:52

  18. Oliver Klee voted on patch set 4 V +1 10/25/26, 13:07

  19. Simon Schaufelberger voted on patch set 4 CR +1 V +1 10/26/26, 22:52

  20. Oli Bartsch voted on patch set 4 CR +2 V +2 10/27/26, 20:59

  21. Oli Bartsch merged patch set 5 10/27/26, 20:59