Review main Merged

96536[TASK] Avoid with() on stubbed method in Messenger tests

Benni Mack CR +2 V +2 Easy +2 −2 updated 10/08/26, 14:57

Commit message

Since PHPUnit 13, method() on a mock returns an InvocationStubber,
which does not declare with(). PHPStan reports the calls in the
Doctrine connection middleware tests as undefined methods.

A return map keeps the restriction to the "Default" connection.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Benni Mack uploaded patch set 1 10/08/26, 14:44

  2. Georg Ringer voted on patch set 1 CR +1 V +1 10/08/26, 14:45

  3. Oliver Klee voted on patch set 1 CR +1 V +1 10/08/26, 14:47

  4. core-ci voted on patch set 1 V +1 10/08/26, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110512

  5. Benni Mack voted on patch set 1 CR +2 V +2 10/08/26, 14:57

  6. Benni Mack merged patch set 2 10/08/26, 14:57