Review main Merged

96537[FEATURE] Improve the overview of the reactions module

Oli Bartsch CR +2 V +2 Expert +1532 −82 updated 10/10/26, 16:54

Commit message

The reactions module did not explain what it is for, and its list did
not tell whether a reaction can work or is used at all.

The module now introduces itself and, without any reaction, offers a
card per registered reaction type that opens the form with the type
preselected. The list shows the target table and storage page, the
impersonated user and the last call of each reaction, and can be
filtered and sorted by them.

The last call is stored in the new fields last_called, last_status and
last_failure. Only calls that passed the secret check are recorded,
written directly without DataHandler, and the fields are reset when a
reaction is copied.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 1015

  1. Oli Bartsch uploaded patch set 1 10/08/26, 16:25

  2. core-ci voted on patch set 1 V -1 10/08/26, 16:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110517

  3. Oli Bartsch uploaded patch set 2 V -1 10/08/26, 19:52

  4. core-ci voted on patch set 2 V -1 10/08/26, 20:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110524

  5. Oli Bartsch rebased onto patch set 3 V -1 10/09/26, 10:31

  6. core-ci voted on patch set 3 V -1 10/09/26, 10:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110583

  7. core-ci voted on patch set 3 V +1 10/10/26, 07:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110583

  8. Simon Schaufelberger commented on patch set 3 10/10/26, 09:18

    ReactionResolver.php:92

    Please add more context which reaction failed, otherwise this log mage is not helpful

    ReactionResolver.php:125

    More context about the reaction please like the name
  9. Oli Bartsch uploaded patch set 4 V +1 10/10/26, 10:20

  10. Oli Bartsch commented on patch set 4 10/10/26, 10:27

    ReactionResolver.php:92 Reply

    Done

    ReactionResolver.php:125 Reply

    Done
  11. core-ci voted on patch set 4 V +1 10/10/26, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110792

  12. Benni Mack voted on patch set 4 CR +1 V +1 10/10/26, 10:35

  13. Simon Schaufelberger voted on patch set 4 CR +1 V +1 10/10/26, 11:42

  14. Oli Bartsch voted on patch set 4 CR +2 V +2 10/10/26, 16:54

  15. Oli Bartsch merged patch set 5 10/10/26, 16:54