Review main Merged

96541[BUGFIX] Initialize CKEditor only after the document is parsed

Georg Ringer CR +2 V +2 Normal +118 −46 updated 10/15/26, 08:35

Commit message

The rich-text element may be upgraded while the document is still
being parsed, e.g. when its module is served from the browser cache.
If the response stalls inside the textarea, CKEditor is created with
the partial value received so far and writes that truncated value
back on submit, silently cutting off the rest of the field.

CKEditor is now initialized after DOMContentLoaded if the document is
still loading. Elements inserted later, such as inline records loaded
via AJAX, are not delayed.

The paths of the CKEditor modules in the import map of the JavaScript
unit tests are corrected, as they were not used before.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1114

  1. Georg Ringer uploaded patch set 1 10/08/26, 20:34

  2. Georg Ringer commented on patch set 1 10/08/26, 20:34

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 10/08/26, 20:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110528

  4. Georg Ringer rebased onto patch set 2 V -1 10/09/26, 08:51

  5. Andreas Kienast commented on patch set 2 CR -1 10/09/26, 08:53

    ckeditor5.ts:100

    Can't we use the already existing `DocumentService` for this?
  6. core-ci voted on patch set 2 V +1 10/09/26, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110567

  7. Georg Ringer uploaded patch set 3 CR -1 V +1 10/09/26, 09:09

  8. core-ci voted on patch set 3 V +1 10/09/26, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110571

  9. Georg Ringer commented on patch set 3 10/09/26, 10:46

    ckeditor5.ts:100 Reply

    Done
  10. Benjamin Franzke voted on patch set 3 CR +1 V +1 10/09/26, 11:25

  11. Garvin Hicking voted on patch set 3 CR +1 V +1 10/09/26, 21:00

  12. Georg Ringer voted on patch set 3 CR +2 V +2 10/10/26, 05:07

  13. Georg Ringer merged patch set 4 10/10/26, 05:18

  14. Garvin Hicking wrote 10/15/26, 08:35

    Hashtag added: no-backport